_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

pkg/jobmanager/mainserverconn.go (1)

45-46: Commented-out code left in place.

Consider removing the commented-out log line entirely rather than leaving it as dead code. If needed for future debugging, it can be recovered from version control.

pkg/wavebase/wavebase.go (1)

439-443: filepath.Join produces OS-specific paths, but functions are documented as "remote" (Unix) paths.

These functions use filepath.Join, which uses backslashes on Windows. Since they're labeled "on remote machine" (implying Unix), if these are ever called from a Windows client to compute a remote path, the result would be incorrect. Currently all call sites run on Unix, so this is safe today — just worth noting for future maintainers.

Also, MakeJobDomainSocket in pkg/jobmanager/jobmanager.go (line 380) independently computes the same socketDir. Consider having it call GetRemoteJobSocketPath for the full path to avoid duplication (it already does at line 386 for socketPath, but still computes socketDir separately for MkdirAll).

pkg/jobmanager/jobmanager.go (1)

379-386: Socket directory computed twice — once locally, once via wavebase.

Line 380 computes socketDir inline, while line 386 calls wavebase.GetRemoteJobSocketPath(jobId) which also computes the same directory internally. Consider extracting a helper or reusing the wavebase path for MkdirAll as well.

♻️ Suggested simplification

 func MakeJobDomainSocket(clientId string, jobId string) error {
-	socketDir := filepath.Join("/tmp", fmt.Sprintf("waveterm-%d", os.Getuid()))
-	err := os.MkdirAll(socketDir, 0700)
+	socketPath := wavebase.GetRemoteJobSocketPath(jobId)
+	socketDir := filepath.Dir(socketPath)
+	err := os.MkdirAll(socketDir, 0700)
 	if err != nil {
 		return fmt.Errorf("failed to create socket directory: %w", err)
 	}
 
-	socketPath := wavebase.GetRemoteJobSocketPath(jobId)

• X
• Mastodon
• Reddit
• LinkedIn